feat(errors): Show specific error for conversion failure (#1063)

box · Sep 3, 2019 · effb263 · effb263
1 parent d2deb4d
commit effb263
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/src/lib/RepStatus.js b/src/lib/RepStatus.js
@@ -134,6 +134,9 @@ class RepStatus extends EventEmitter {
                     case ERROR_CODE.CONVERSION_UNSUPPORTED_FORMAT:
                         errorMessage = __('error_bad_file');
                         break;
+                    case ERROR_CODE.CONVERSION_FAILED:
+                        errorMessage = __('error_reupload');
+                        break;
                     default:
                         errorMessage = __('error_refresh');
                         break;

diff --git a/src/lib/__tests__/RepStatus-test.js b/src/lib/__tests__/RepStatus-test.js
@@ -226,6 +226,20 @@ describe('lib/RepStatus', () => {
             repStatus.handleResponse();
         });
 
+        it('should reject with the re upload message if the rep status is error due to conversion failure', done => {
+            sandbox
+                .mock(repStatus)
+                .expects('reject')
+                .callsFake(err => {
+                    expect(err.displayMessage).to.equal(__('error_reupload'));
+                    done();
+                });
+            repStatus.representation.status.state = 'error';
+            repStatus.representation.status.code = 'error_conversion_failed';
+
+            repStatus.handleResponse();
+        });
+
         it('should resolve if the rep status is success', () => {
             sandbox.mock(repStatus).expects('resolve');
             repStatus.representation.status.state = 'success';

diff --git a/src/lib/events.js b/src/lib/events.js
@@ -22,6 +22,7 @@ export const ERROR_CODE = {
     BROWSER_GENERIC: 'error_browser_generic',
     BROWSER_UNSUPPORTED: 'error_browser_unsupported',
     CONTENT_DOWNLOAD: 'error_content_download',
+    CONVERSION_FAILED: 'error_conversion_failed',
     CONVERSION_GENERIC: 'error_conversion_generic',
     CONVERSION_PASSWORD_PROTECTED: 'error_password_protected',
     CONVERSION_TRY_AGAIN_LATER: 'error_try_again_later',