fix(archive): Fix blank screen when sorting #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickr
commented
Jan 16, 2020
mickr
commented
- Add try/catch handler for exceptions
- Handle case when sorting data is falsy
* Add try/catch handler for exceptions * Handle case when sorting data is falsy
|
Verified that @mickr has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Jan 16, 2020
| if (typeof a[sortBy] === 'number' && typeof b[sortBy] === 'number') { | ||
| return a[sortBy] - b[sortBy]; | ||
| } | ||
| try { |
There was a problem hiding this comment.
It seems like we should be able to guard against pretty much any issues without resorting to try/catch here. I think we should add a componentDidCatch to the parent component, though.
There was a problem hiding this comment.
I think we are safe as well, but I through it in for good measure to ensure we always get an itemList returned.
There was a problem hiding this comment.
Ideally, try/catch should be reserved for exception handling rather than for flow control. I don't think it hurts in this case, but it can get overused.
mickr
force-pushed
the
fix-sort-blank-screen
branch
from
3b69845
to
8daf600
Compare
mickr
force-pushed
the
fix-sort-blank-screen
branch
from
8daf600
to
e8755db
Compare
jstoffan
previously approved these changes
Jan 16, 2020
* Remove try/catch * Add test for comparing to null values in the sort
jstoffan
approved these changes
Jan 17, 2020
|
I will follow this up with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.