Chore: Default single page images to page 1 for annotations #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodsum
commented
Jul 26, 2017
| @@ -89,6 +89,13 @@ class ImageAnnotator extends Annotator { | |||
| */ | |||
| createAnnotationThread(annotations, location, type) { | |||
| let thread; | |||
|
|
|||
| // Corrects any image annotation page number to 1 instead of -1 | |||
| const fixedLocation = location; | |||
There was a problem hiding this comment.
This should cover backwards compatibility for anyone who created an image annotation before this commit was merged in
pramodsum
force-pushed
the
image
branch
2 times, most recently
from
a6547bb
to
a57a495
Compare
JustinHoldstock
approved these changes
Jul 27, 2017
| @@ -41,7 +41,7 @@ export function findClosestElWithClass(element, className) { | |||
| */ | |||
| export function getPageInfo(element) { | |||
| const pageEl = findClosestElWithClass(element, 'page') || null; | |||
| let page = -1; | |||
| let page = 1; | |||
There was a problem hiding this comment.
Make sure that this works. I know we do some explicit checks for page === -1 so that we can check where events occur on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.