Add support for all streams for uploading files #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2399
💛 - Coveralls |
PJSimon
reviewed
Jun 24, 2020
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
sujaygarlanka
commented
Jun 24, 2020
PJSimon
approved these changes
Jun 24, 2020
|
It still doesn't work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #463. Streams other than fs streams could not be used to upload files because these streams don't have the stream length as part of the stream, which is required to upload a file. We now allow a user to pass in the stream length through the options parameter for
Files.uploadFileandFiles.uploadNewFileVersion, so other streams are now supported. Solution was inspired by #143.