fix: Retry Connection broken and Connection reset requests errors (…

…#794) Closes: SDK-2904
box · Jan 27, 2023 · f1a0aa4 · f1a0aa4
1 parent c0b2cd4
commit f1a0aa4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/boxsdk/session/session.py b/boxsdk/session/session.py
@@ -337,7 +337,9 @@ def _prepare_and_send_request(
             network_response = None
             if 'EOF occurred in violation of protocol' in str(request_exc):
                 reauthentication_needed = True
-            elif 'Connection aborted' in str(request_exc):
+            elif any(text in str(request_exc) for text in [
+                'Connection aborted', 'Connection broken', 'Connection reset'
+            ]):
                 reauthentication_needed = False
             else:
                 raise

diff --git a/test/unit/session/test_session.py b/test/unit/session/test_session.py
@@ -231,8 +231,14 @@ def test_box_session_raises_for_failed_response(box_session, mock_network_layer,
         box_session.get(url=test_url)
 
 
-def test_box_session_retries_connection_aborted_exception(box_session, mock_network_layer, generic_successful_request_response, test_url):
-    mock_network_layer.request.side_effect = [RequestsConnectionError('Connection aborted'), generic_successful_request_response]
+@pytest.mark.parametrize('exc_message', [
+    'Connection aborted',
+    "Connection broken: ConnectionResetError(54, 'Connection reset by peer')"
+])
+def test_box_session_retries_connection_aborted_exception(
+        box_session, mock_network_layer, generic_successful_request_response, test_url, exc_message
+):
+    mock_network_layer.request.side_effect = [RequestsConnectionError(exc_message), generic_successful_request_response]
     mock_network_layer.retry_after.side_effect = lambda delay, request, *args, **kwargs: request(*args, **kwargs)
 
     box_response = box_session.get(url=test_url)