Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vanity_name param for creating shared link to a file or folder #637

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-1815

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2666

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.739%

Totals Coverage Status
Change from base Build 2664: 0.002%
Covered Lines: 3174
Relevant Lines: 3281

💛 - Coveralls

This method returns a `unicode` string containing the shared link URL.

<!-- sample put_folders_id add_shared_link -->
```python
file_id = '11111'
folder_id = '11111'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you replace the file shared link sample with a folder shared link sample?

Copy link
Contributor Author

@lukaszsocha2 lukaszsocha2 Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is folders.md refering to examples for folder not files. The usage of the creating shared link for file is in files.md line 661.

@lukaszsocha2 lukaszsocha2 merged commit eb52a74 into main Nov 26, 2021
@lukaszsocha2 lukaszsocha2 deleted the sdk-1815-add-vanity_name-param-for-shared-links branch November 26, 2021 16:05
DaveSawyer pushed a commit to DaveSawyer/box-python-sdk that referenced this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants