chore(content-preview): Pass token generator to preview library #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @mxiao6 has signed the CLA. Thanks for the pull request! |
ConradJChan
reviewed
Oct 24, 2019
| @@ -700,8 +700,7 @@ class ContentPreview extends React.PureComponent<Props, State> { | |||
| } | |||
|
|
|||
| const fileOpts = { ...fileOptions }; | |||
| const typedId: string = getTypedFileId(fileId); | |||
| const token: TokenLiteral = await TokenService.getReadToken(typedId, tokenOrTokenFunction); | |||
| const token = typedId => TokenService.getReadTokens(typedId, tokenOrTokenFunction); | |||
There was a problem hiding this comment.
Do we even need the argument in the token function? Since we know what file we're generating the token for, can we instead do const token = () => TokenService.getReadToken(typedId, tokenOrTokenFunction)?
There was a problem hiding this comment.
If I get rid of the argument, I have to change the preview lib's getTokens function, which I don't think we should touch.
ConradJChan
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related preview change: box/box-content-preview#1087