BackupClientContext::CloseAnyOpenConnection: don't silently ignore er…

…rors

Now that we can do significant writeback work during connection cleanup, it's
not appropriate to silently ignore and swallow errors. Really we should retry
this work, but I'm not yet sure what the best retry policy would be.

lib/bbackupd/BackupClientContext.cpp

@@ -182,29 +182,31 @@ BackupProtocolCallable* BackupClientContext::GetOpenConnection() const
 // --------------------------------------------------------------------------
 void BackupClientContext::CloseAnyOpenConnection()
 {
+	// Delete any pending list
+	if(mpDeleteList != 0)
+	{
+		delete mpDeleteList;
+		mpDeleteList = 0;
+	}
+
 	BackupProtocolCallable* pConnection(GetOpenConnection());
 	if(pConnection)
 	{
 		try
 		{
-			// Quit nicely
+			// Quit nicely:
 			pConnection->QueryFinished();
 		}
 		catch(...)
 		{
-			// Ignore errors here
+			// Close the connection anyway:
+			mapConnection.reset();
+			throw;
 		}
 
-		// Delete it anyway.
+		// Close the connection
 		mapConnection.reset();
 	}
-
-	// Delete any pending list
-	if(mpDeleteList != 0)
-	{
-		delete mpDeleteList;
-		mpDeleteList = 0;
-	}
 }