Set the global node version in the site manifest

[smcnabb]

It doesn't look like the global node version gets set anywhere. I had to add this change to our site manifest to fix.

Before:

Last login: Wed Jun 19 11:39:04 on ttys002
nodenv: couldn't find any version specified for use
smcnabb@mac:~ $ node --version
nodenv: couldn't find any version specified for use
smcnabb@mac:~ $ nodenv version
nodenv: couldn't find any version specified for use
smcnabb@mac:~ $ set | grep NODE
NODENV_ROOT=/opt/boxen/nodenv
NODE_PATH=/opt/boxen/nodenv/versions//lib/

After:

Last login: Wed Jun 19 11:39:14 on ttys002
smcnabb@mac:~ $ node --version
v0.10.7
smcnabb@mac:~ $ nodenv version
v0.10
smcnabb@mac:~ $ set | grep NODE
NODENV_ROOT=/opt/boxen/nodenv
NODE_PATH=/opt/boxen/nodenv/versions/v0.10/lib/

[rafaelfranca]

In my opinion this should be set in your organization project.

[ocxo]

I think having a global node version would be useful in some cases.

[smcnabb]

@rafaelfranca I would agree if there weren't node versions being installed in the site manifest file. Since there are I think it would be helpful to at least setup one as the default.

[rafaelfranca]

So 👍

[rafaelfranca]

I removed these version on my organization project.

[wfarr]

I quite agree.

Defaults are nice and all, but the override for this is hack-ish at best. This change likely should be backed out and discussed further.

On Jun 19, 2013, at 11:48 AM, Rafael Mendonça França notifications@github.com wrote:

In my opinion this should be set in your organization project.

—
Reply to this email directly or view it on GitHub.

[rafaelfranca]

I'll revert it. Thanks for your input.

[smcnabb]

@wfarr Sorry, I didn't realize I was being hacky - I'm still learning boxen and puppet. I'd be happy to take another crack at this if you could suggest a better approach?

[wfarr]

@smcnabb So the part that makes this hacky is any override behavior.

What I'd like to do is have a Pull Request against the nodejs repo that adds a global_version or default_version parameter to the nodejs class, which is overridable via Hiera, that sets nodejs::global to the expected version. We can then default this to the latest stable version.

The reason this particular approach is IMO better is that for anyone forking this repo, in the future, they'll be able to simply edit a yaml file in this repo to change things like the default nodejs, ruby, etc versions. And in fact, Hiera makes it easy for users to do this for themselves with overrides. This makes customizing one's own environment super easy to understand without having to understand Puppet itself.

[henry74]

So what's the right way to do this right now?

[wfarr]

class { 'nodejs::global':
  version => 'v0.10'
}