Skip to content
This repository has been archived by the owner on May 22, 2018. It is now read-only.

added Puppetfile.lock into gitignore; Some cleaning is a good practice; Please merge it into master #721

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2015

No description provided.

@dgoodlad
Copy link
Contributor

👎 Puppetfile.lock is required, primarily for bootstrapping. Why do you want to remove it?

@dgoodlad dgoodlad closed this Feb 22, 2015
@ghost
Copy link
Author

ghost commented Feb 22, 2015

required for bootstrapping?

Just created when puppet is processed.

@dgoodlad
Copy link
Contributor

Without Puppetfile.lock, same as Gemfile.lock, you can end up with a dependency cycle – think authentication – when you bootstrap a brand new machine.

Again, why do you think this file should be removed?

@ghost
Copy link
Author

ghost commented Feb 22, 2015

isn't it created by Puppet for the first time (even for bootstrapping) ?

@dgoodlad
Copy link
Contributor

@julienlavergne it may be regenerated if you've changed Puppetfile (by librarian-puppet, not by Puppet), but that shouldn't be happening when bootstrapping

@ghost
Copy link
Author

ghost commented Feb 22, 2015

@dgoodlad effectively using librarian-puppet prevents it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants