Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Add localhost as a resolver #9

Closed
wants to merge 1 commit into from

Conversation

grosser
Copy link

@grosser grosser commented Nov 22, 2013

@tmcinerney
Copy link
Contributor

👍

@grosser
Copy link
Author

grosser commented Nov 25, 2013

@wfarr mergable ?

@hrp hrp mentioned this pull request May 15, 2014
@grosser
Copy link
Author

grosser commented Jul 22, 2014

pong, merge ?

@dgoodlad
Copy link
Contributor

👎

If we're changing this default, it's going to be contentious. Let's start with making it a configurable option (via hiera and a parameterized class), then the default can be changed independently.

@dgoodlad dgoodlad closed this Aug 14, 2014
@grosser
Copy link
Author

grosser commented Aug 14, 2014

What is bad about adding another resolve ?

Now using this fix ...

  # resolve localhost + localhost.com
  # https://github.com/boxen/puppet-dnsmasq/pull/9
  File <| title == "${dnsmasq::config::configdir}/dnsmasq.conf" |> {
    source => undef,
    content => inline_template("<%=
      root = scope.lookupvar('boxen::config::home') + '/repo'
      File.read(root + '/shared/dnsmasq/files/dnsmasq.conf') + File.read(root + '/modules/ours/files/dnsmasq.conf')
    %>")
  }

@dgoodlad
Copy link
Contributor

@grosser taking over that zone completely and arbitrarily is not something I want to do without making it configurable.

@grosser
Copy link
Author

grosser commented Nov 12, 2014

now it's configurable, but still cannot add more, would this work ?

dnsmas::add: "address=/localhost.com/127.0.0.1\naddress=/localhost/127.0.0.1"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants