-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2nd viz] GraphQL query for createdBoxes #917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add items_count - save one join with ProductCategory - make join condition DbChangeHistory-Box more precise - remove enum conversion (GraphQL does it itself)
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
+ Coverage 71.25% 71.30% +0.05%
==========================================
Files 285 285
Lines 7214 7232 +18
Branches 1521 1525 +4
==========================================
+ Hits 5140 5157 +17
Misses 2040 2040
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MaikNeubert
approved these changes
Aug 11, 2023
HaGuesto
added this to the 2nd viz: Boxes created by product and category in a certain timeframe milestone
Aug 11, 2023
pylipp
force-pushed
the
feature/created-boxes-back-end-query
branch
from
August 11, 2023 17:06
2dcdc04
to
5654021
Compare
pylipp
changed the title
GraphQL query for createdBoxes
[2nd viz] GraphQL query for createdBoxes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the new public GraphQL query
createdBoxes
.The interface has been defined in #898.
Please verify that you can run a query like
without errors. In the response
facts
is expected to contain several elements;dimensions
returns sensible data, too.Note that the implementation is not precise with regards to possible changes in box product or item count that might have happened since creation.