Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2nd viz] GraphQL query for createdBoxes #917

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Aug 10, 2023

This brings the new public GraphQL query createdBoxes.

The interface has been defined in #898.

Please verify that you can run a query like

query { createdBoxes { facts { boxesCount } dimensions { product { id } category { id } } } }

without errors. In the response facts is expected to contain several elements; dimensions returns sensible data, too.

Note that the implementation is not precise with regards to possible changes in box product or item count that might have happened since creation.

@pylipp pylipp linked an issue Aug 10, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #917 (2dcdc04) into master (f9b35ec) will increase coverage by 0.05%.
The diff coverage is 95.00%.

❗ Current head 2dcdc04 differs from pull request most recent head 5654021. Consider uploading reports for the commit 5654021 to get more accurate results

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   71.25%   71.30%   +0.05%     
==========================================
  Files         285      285              
  Lines        7214     7232      +18     
  Branches     1521     1525       +4     
==========================================
+ Hits         5140     5157      +17     
  Misses       2040     2040              
- Partials       34       35       +1     
Flag Coverage Δ
backend 96.90% <95.00%> (-0.02%) ⬇️
frontend 51.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
back/boxtribute_server/exceptions.py 92.18% <ø> (ø)
...oxtribute_server/business_logic/statistics/crud.py 96.96% <93.33%> (-3.04%) ⬇️
...ribute_server/business_logic/statistics/queries.py 100.00% <100.00%> (ø)
back/boxtribute_server/graph_ql/schema.py 100.00% <100.00%> (ø)

@pylipp pylipp force-pushed the feature/created-boxes-back-end-query branch from 2dcdc04 to 5654021 Compare August 11, 2023 17:06
@pylipp pylipp merged commit 6dbe91f into master Aug 11, 2023
13 checks passed
@pylipp pylipp deleted the feature/created-boxes-back-end-query branch August 11, 2023 17:14
@pylipp pylipp changed the title GraphQL query for createdBoxes [2nd viz] GraphQL query for createdBoxes Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Merged to staging
Development

Successfully merging this pull request may close these issues.

[2nd viz] BE public graphQL query: statistics about created boxes
3 participants