fix #113 : a malformed magnet may cause lock unreleased

boypt · Apr 21, 2021 · f0b898b · f0b898b
1 parent 9cc5947
commit f0b898b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/engine/engine.go b/engine/engine.go
@@ -140,10 +140,10 @@ func (e *Engine) NewMagnet(magnetURI string) error {
 	log.Println("[NewMagnet] called: ", magnetURI)
 	e.RLock()
 	tt, err := e.client.AddMagnet(magnetURI)
+	e.RUnlock()
 	if err != nil {
 		return err
 	}
-	e.RUnlock()
 	e.newMagnetCacheFile(magnetURI, tt.InfoHash().HexString())
 	return e.addTorrentTask(tt)
 }
@@ -153,10 +153,10 @@ func (e *Engine) NewTorrentBySpec(spec *torrent.TorrentSpec) error {
 	log.Println("[NewTorrentBySpec] called ")
 	e.RLock()
 	tt, _, err := e.client.AddTorrentSpec(spec)
+	e.RUnlock()
 	if err != nil {
 		return err
 	}
-	e.RUnlock()
 	return e.addTorrentTask(tt)
 }