Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting disfunctional with format csv and by-file option #311

Closed
doomguy opened this issue Jan 2, 2022 · 5 comments
Closed

Sorting disfunctional with format csv and by-file option #311

doomguy opened this issue Jan 2, 2022 · 5 comments
Labels
enhancement New feature or request
Projects

Comments

@doomguy
Copy link

doomguy commented Jan 2, 2022

Describe the bug
Sorting (-s, --sort) doesn't work together with "-f csv" and "--by-file"

To Reproduce

$ scc --by-file -f csv --sort lines gitlab-pages | column -s, -t | head -n 4
Language    Location                                                                                                           Filename                        Lines  Code  Comments  Blanks  Complexity  Bytes
Makefile    gitlab-pages/Makefile.util.mk                                                                                      Makefile.util.mk                68     52    1         15      3           2447
Markdown    gitlab-pages/PROCESS.md                                                                                            PROCESS.md                      80     61    0         19      0           4575
License     gitlab-pages/LICENSE                                                                                               LICENSE                         19     16    0         3       0           1046

Expected behavior
The rows are sorted by lines.

Desktop (please complete the following information):

  • OS: macOS
  • Version 3.0.0
  • Install Source: homebrew

Thanks for looking into it!
/Doomguy

@doomguy doomguy changed the title Sorting disfunctional with format csv Sorting disfunctional with format csv and by-file option Jan 2, 2022
@boyter boyter added the enhancement New feature or request label Jan 3, 2022
@boyter
Copy link
Owner

boyter commented Jan 3, 2022

Technically not dysfunctional. Its not present at all :P

I never put it in because, well CSV you should be able to sort it yourself :) I guess I can add it though.

@boyter boyter added this to Todo in 3.1.0 Jan 3, 2022
boyter added a commit that referenced this issue Jan 4, 2022
@boyter
Copy link
Owner

boyter commented Jan 4, 2022

@doomguy If you are able to build from source that should work for you as expected now.

@boyter boyter moved this from Todo to Done in 3.1.0 Jan 4, 2022
@doomguy
Copy link
Author

doomguy commented Jan 4, 2022

Can confirm - lines are now sorted. Thank you a lot 💜

I do however have the problem now that there is no header line anymore in CSVs:

# homebrew@3.0.0
% scc --by-file -f csv gitlab-pages | head -n1
Language,Location,Filename,Lines,Code,Comments,Blanks,Complexity,Bytes
# github master branch as of 2022-01-04
% ../../bin/scc/scc --by-file -f csv gitlab-pages | head -n1
Go,gitlab-pages/test/acceptance/zip_test.go,zip_test.go,377,332,7,38,12,11313

Was this intentional?

Regards
/Doomguy

boyter added a commit that referenced this issue Jan 4, 2022
@boyter
Copy link
Owner

boyter commented Jan 4, 2022

100% something I missed. Its still in there, just sorted somewhere. Resolved now so headers should be both at the top. I did it correctly for the summary, just not the full files listing. A quick update should resolve this for you.

@doomguy
Copy link
Author

doomguy commented Jan 5, 2022

Works now as desired. Thanks a lot! 💜

@doomguy doomguy closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
3.1.0
Done
Development

No branches or pull requests

2 participants