Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: parse list of inputs from a file #329

Closed
Warchant opened this issue Apr 1, 2022 · 1 comment · Fixed by #330
Closed

Feature Request: parse list of inputs from a file #329

Warchant opened this issue Apr 1, 2022 · 1 comment · Fixed by #330
Labels
enhancement New feature or request

Comments

@Warchant
Copy link
Contributor

Warchant commented Apr 1, 2022

I have a use-case to run scc on a list of files. This can be done by providing all files in CLI args.
On Windows there's a limit of 2**15 chars for a single CLI command, which limits the number of input files that can be used.

I see 2 solutions:

  1. Implement "scc @flags.txt" flag parsing syntax, where flags.txt is a text file which has 1 flag per line. Related issue in cobra: Does cobra support "@file.txt" flag syntax? spf13/cobra#1649
  2. Add a flag --from-file inputs.txt which will read list of input files/folders from inputs.txt.

Any feedback? I'd implement one of these features.

@Warchant Warchant changed the title Feature Request: parse list of input files/folders from a file Feature Request: parse list of inputs from a file Apr 1, 2022
@boyter
Copy link
Owner

boyter commented Apr 3, 2022

Now that's something I had not considered. I would probably want to go with option 1 out of the above since it is used elsewhere, unless its order of magnitude harder to develop.

Happy to merge this in if you do implement it!

@boyter boyter added the enhancement New feature or request label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants