Skip to content

Commit

Permalink
Remove unused variable BINARY (#57)
Browse files Browse the repository at this point in the history
I run per default [Shellcheck](https://github.com/koalaman/shellcheck) on every script I run and for the godownloader.sh script it complains about an unused variable `BINARY`:

```
➜  ~ shellcheck /tmp/godownloader.sh 

In /tmp/godownloader.sh line 340:
BINARY=kail
^----^ SC2034: BINARY appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- BINARY appears unused. Verify use...

```
This references to the line `BINARY=kail` in the main program of the script at this line https://github.com/boz/kail/blob/58d7816d3d93cccb1903603512e40919a843c760/godownloader.sh#L340

It seems to me that the BINARY variable is deprecated and not used any more as the REPO and PROJECT_NAME references to kail and we get from there the release data.
As I find it confusing and shellcheck should pass for any system related program with access to a possible production cluster IMHO,
I think it's either time to remove the BINARY completely or if it not intended, the PR is a wake up in case :-)
  • Loading branch information
hanfried committed Jun 2, 2021
1 parent efd503d commit 7b1aa99
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion godownloader.sh
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@ EOF
PROJECT_NAME="kail"
OWNER=boz
REPO="kail"
BINARY=kail
FORMAT=tar.gz
OS=$(uname_os)
ARCH=$(uname_arch)
Expand Down

0 comments on commit 7b1aa99

Please sign in to comment.