Remove unused variable BINARY #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run per default [Shellcheck](https://github.com/koalaman/shellcheck) on every script I run and for the godownloader.sh script it complains about an unused variable `BINARY`: ``` ➜ ~ shellcheck /tmp/godownloader.sh In /tmp/godownloader.sh line 340: BINARY=kail ^----^ SC2034: BINARY appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC2034 -- BINARY appears unused. Verify use... ``` This references to the line `BINARY=kail` in the main program of the script at this line https://github.com/boz/kail/blob/58d7816d3d93cccb1903603512e40919a843c760/godownloader.sh#L340 It seems to me that the BINARY variable is deprecated and not used any more as the REPO and PROJECT_NAME references to kail and we get from there the release data. As I find it confusing and shellcheck should pass for any system related program with access to a possible production cluster IMHO, I think it's either time to remove the BINARY completely or if it not intended, the PR is a wake up in case :-)
|
Thanks @hanfried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run per default Shellcheck on every script I run and for the godownloader.sh script it complains about an unused variable
BINARY:This references to the line
BINARY=kailin the main program of the script at this linekail/godownloader.sh
Line 340 in 58d7816
It seems to me that the BINARY variable is deprecated and not used any more as the REPO and PROJECT_NAME references to kail and we get from there the release data.
As I find it confusing and shellcheck should pass for any system related program with access to a possible production cluster IMHO,
I think it's either time to remove the BINARY completely or if it not intended, the PR is a wake up in case :-)