Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly allows to register binary data in virtual file system #1375

Merged
merged 1 commit into from
May 19, 2018

Conversation

blikblum
Copy link
Contributor

Currently if a binary data (e.g. ArrayBuffer instance) is registered in pdfmake.vfs it works by accident

The parameter 'base64' is passed to Buffer constructor which pass down, inside Buffer implementation, to a Uint8Array constructor as the byteOffset. Luckily seems that Uint8Array constructor works in this case but could not

This PR checks for content type when creating vfs buffer so ensure no incorrect param is passed down

@liborm85 liborm85 merged commit 9fb91d6 into bpampuch:master May 19, 2018
@blikblum blikblum deleted the vfs-binary branch May 19, 2018 09:45
@blikblum
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants