Explicitly allows to register binary data in virtual file system #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a binary data (e.g. ArrayBuffer instance) is registered in pdfmake.vfs it works by accident
The parameter 'base64' is passed to Buffer constructor which pass down, inside Buffer implementation, to a Uint8Array constructor as the byteOffset. Luckily seems that Uint8Array constructor works in this case but could not
This PR checks for content type when creating vfs buffer so ensure no incorrect param is passed down