Unify and fix string comparison codegen #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two versions of string comparison codegen (CreateStrncmp) - one for comparing two on-stack strings and one for comparing an on-stack string with a string literal. The version for comparing with literals contained a bug which caused two non-equal strings where one is a prefix of the other to be compaed as equal. This commit unifies the two functions into one and fixes the bug. Also, it adds a number of runtime tests that previously did not pass. Note: the expected result of one existing test was changed since the tested behaviour of strncmp did not match the behaviour of C's strncmp.
viktormalik
force-pushed
the
strcmp-fix
branch
from
bef9bc4
to
606c478
Compare
viktormalik
commented
Aug 23, 2021
danobi
approved these changes
Aug 24, 2021
|
|
||
| assert(val1p->getElementType()->isArrayTy() && | ||
| val1p->getElementType()->getArrayElementType() == getInt8Ty()); | ||
| #ifndef NDEBUG |
There was a problem hiding this comment.
Should it be #ifdef NDEBUG instead?
There was a problem hiding this comment.
Hm, I just used what was originally there, but I think that it's correct: if NDEBUG is defined (i.e. debug mode is off), don't run the assertions.
fbs
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1978.
There were two versions of string comparison codegen (
CreateStrncmp) - one for comparing two on-stack strings and one for comparing an on-stack string with a string literal. The version for comparing with literals was wrong and caused the linked bug.This PR unifies the two functions into one and fixes the bug.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md