Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm, lxc): add new initialization.dns.servers param to vm and container #832

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

rafsaf
Copy link
Contributor

@rafsaf rafsaf commented Dec 22, 2023

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Added servers param, deprecate old server param. Apply AFAIK works as expected, tried some of combinations:

  • old server and no servers
  • both server and servers
  • new servers without server
  • old server and no servers -> apply -> then only servers

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #816

…erver param

Signed-off-by: rafsaf <rafal.safin12@gmail.com>
@bpg bpg changed the title feat(vm) add new servers param to vm and container feat(vm, lxc): add new initialization.dns.servers param to vm and container Dec 23, 2023
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this, @rafsaf!

LGTM! 🚀

@bpg bpg merged commit 16e571d into bpg:main Dec 23, 2023
8 checks passed
@ghost ghost mentioned this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Multiple DNS Servers for proxmox_virtual_environment_container and in vm template
2 participants