Abstract client rest.Config behind an interface #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too bad discovery.NewDiscoveryClientForConfigOrDie() and
dynamic.NewDynamicClientPool() expects a concrete *rest.Config
struct rather than a kubernetes.Interface (clientset).
We can still wrap this rest.Config behind an interface. That's
a first step before we can, progressively, get rid of Config
(and run.go), which would make pkg/ content more like reusable
packages rather than a frameworkish bunch of files.