Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract client rest.Config behind an interface #44

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Abstract client rest.Config behind an interface #44

merged 1 commit into from
Apr 24, 2018

Commits on Apr 23, 2018

  1. Abstract client rest.Config behind an interface 

    Too bad discovery.NewDiscoveryClientForConfigOrDie() and
dynamic.NewDynamicClientPool() expects a concrete *rest.Config
struct rather than a kubernetes.Interface (clientset).

We can still wrap this rest.Config behind an interface. That's
a first step before we can, progressively, get rid of Config
(and run.go), which would make pkg/ content more like reusable
packages rather than a frameworkish bunch of files.
    @bpineau
    bpineau committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    069beb4 View commit details
    Browse the repository at this point in the history