feat: eagerly validate

Always validate, indicate results in overlay. Toggle overlays on button click.
bpmn-io · Jul 18, 2023 · a2eb8fb · a2eb8fb
1 parent c7c8ee7
commit a2eb8fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/lib/Linting.js b/lib/Linting.js
@@ -73,9 +73,7 @@ export default function Linting(
     'linting.configChanged',
     'linting.toggle'
   ], LOW_PRIORITY, function(e) {
-    if (self.isActive()) {
-      self.update();
-    }
+    self.update();
   });
 
   eventBus.on('linting.toggle', function(event) {
@@ -267,7 +265,10 @@ Linting.prototype.update = function() {
     add = assign(add, update);
 
     self._clearOverlays();
-    self._createIssues(add);
+
+    if (self.isActive()) {
+      self._createIssues(add);
+    }
 
     self._issues = newIssues;
 
@@ -496,12 +497,6 @@ Linting.prototype._setButtonState = function(state, errors, warnings) {
 
 Linting.prototype._updateButton = function() {
 
-  if (!this.isActive()) {
-    this._setButtonState('inactive', 0, 0);
-
-    return;
-  }
-
   var errors = 0,
       warnings = 0;
 
@@ -525,7 +520,7 @@ Linting.prototype._createButton = function() {
   var self = this;
 
   this._button = domify(
-    '<button class="bjsl-button bjsl-button-inactive" title="' + this._translate('Toggle linting') + '"></button>'
+    '<button class="bjsl-button bjsl-button-inactive" title="' + this._translate('Toggle linting overlays') + '"></button>'
   );
 
   this._button.addEventListener('click', function() {

diff --git a/test/spec/LintingSpec.js b/test/spec/LintingSpec.js
@@ -779,7 +779,7 @@ describe('i18n', function() {
     document.body.appendChild(el);
 
     const translations = {
-      'Toggle linting': 'Перемкнути перевірку',
+      'Toggle linting overlays': 'Перемкнути перевірку',
       'Process is missing end event': 'У процеса відсутня завершальна подія',
       '{errors} Errors, {warnings} Warnings': '{errors} помилок, {warnings} попередженнь'
     };