feat: add execution listeners for Zeebe #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
barmac
force-pushed
the
execution-listener
branch
3 times, most recently
from
58982e9
to
7924661
Compare
|
I've presented an alternative UI in which there are sections split by the event type, but for now I'll keep the C7-like option of "bag of all listeners". Discussion done via slack: https://camunda.slack.com/archives/GP70M0J6M/p1720186515761729?thread_ts=1720185492.298049&cid=GP70M0J6M |
barmac
force-pushed
the
execution-listener
branch
from
b150919
to
5d09547
Compare
bpmn-io-tasks
bot
added
needs review
barmac
force-pushed
the
execution-listener
branch
from
5d09547
to
85f02f2
Compare
|
This is now ready for review. |
| return false; | ||
| } | ||
|
|
||
| return isAny(bo, [ |
There was a problem hiding this comment.
Could possibly use metadata available in model: https://github.com/camunda/zeebe-bpmn-moddle/blob/main/resources/zeebe.json#L489
There was a problem hiding this comment.
True. We don't use model metadata anywhere in this project yet, but this could be added.
There was a problem hiding this comment.
I've updated the function to use the model.
barmac
force-pushed
the
execution-listener
branch
from
85f02f2
to
dab617c
Compare
Related to camunda/camunda-modeler#3951 deps: update to `camunda-bpmn-js-behaviors@1.4.0` deps: update to `zeebe-bpmn-moddle@1.2.0`
barmac
force-pushed
the
execution-listener
branch
from
dab617c
to
6376c83
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-07-17.at.10.46.06.mov
Related to camunda/camunda-modeler#3951
Try out via
npm starton the branch.