Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies and changelog #4429

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jarekdanielak
Copy link
Contributor

@jarekdanielak jarekdanielak commented Jul 23, 2024

Proposed Changes

  • feat: change Header value and Field Injection value to text areas (bpmn-io/bpmn-js-properties-panel#1065)
  • feat: support Zeebe execution listeners (bpmn-io/bpmn-js-properties-panel#1048)
  • fix: improve behavior of text areas with autoResize property (#4419)
  • deps: update to camunda-bpmn-js@4.14.0
  • deps: update to @bpmn-io/properties-panel@3.22.3
  • deps: update to bpmn-js-properties-panel@5.19.0
  • deps: update to zeebe-bpmn-moddle@1.2.0

Closes #2982
Closes #4419

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@jarekdanielak jarekdanielak added the dependencies Updates a dependency label Jul 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 23, 2024
@barmac
Copy link
Contributor

barmac commented Jul 23, 2024

Closes #3951 (@barmac)

This is not done yet; it's an epic with a couple of items still to implement.

@nikku
Copy link
Member

nikku commented Jul 24, 2024

Let's follow our established practices for commits:

  • Production dependency updates are marked as deps: {WHAT DEPENDENCIES CHANGED}, if possible grouped semantically (i.e. deps: bump BPMN modeling dependencies)
  • Development dependency updates are marked as chore: {UPDATE TEST DEPENDENCIES OR WHAT NOT}

@jarekdanielak you can have a look into the commit log to see how this usually is done.

@nikku
Copy link
Member

nikku commented Jul 24, 2024

@jarekdanielak I wonder what our strategy was in fixing this. I still see many places in the editor where multi-line is still not supported, but should be:

Missing multi-line support

  • C7 - Any Task - Extension properties - value ➡️ no multi-line support
  • C8 - Any Task - Extension properties - value ➡️ no multi-line support

Missing auto-resize:

  • C7 - Service Task - Inputs - * - value ➡️ multi-line, but does not auto-resize for me:
    capture GTqTsO_optimized
  • C7 - Service Task - Outputs - * - value ➡️ same like inputs
  • C8 - Any Element - Example Data
  • C8 - Any Element - Documentation
  • C7 - Any Element - Documentation

So yea, while we partially fixed these bugs, we did not consistently addressed the user feedback. We could though 🙂.

This relates to bpmn-io/bpmn-js-properties-panel#713. What I indicated there is that I think there is little value in keeping the existing "multi-line, but no auto-resize" behavior we have in some places, but instead rely on "auto-resize any multi-line field". We did not achieve that with the two incorporated fixes.


I don't see the new changes break anything, hence I'm happy to merge them. In the future I'd love to see us advance/clean up things in a more holistic manner 🤩.

@nikku nikku merged commit 3e7a394 into develop Jul 24, 2024
12 checks passed
@nikku nikku deleted the update-deps-changelog-23-07-24 branch July 24, 2024 12:28
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 24, 2024
@github-actions github-actions bot added this to the M79 milestone Jul 24, 2024
@nikku
Copy link
Member

nikku commented Jul 24, 2024

Just for reference, another quirk I found in the auto-resize department: #4419 (comment).

Please consider if it is worth to follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
3 participants