Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render Text#language fields using monospace font #869

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 3, 2023

screenshot XsLXf7

Related to #858

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 3, 2023
@nikku nikku requested review from marstamm and barmac February 3, 2023 10:34
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! I take it the schema support will be added through a dependency update later?

@nikku
Copy link
Member Author

nikku commented Feb 3, 2023

I take it the camunda/element-templates-json-schema#89 will be added through a dependency update later?

YES. It is not strictly necessary.

@nikku nikku merged commit a97afa7 into master Feb 3, 2023
@nikku nikku deleted the text-language-monospace branch February 3, 2023 10:48
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants