fix(viewer): do not clear diagram if no diagram to clear

Closes #1181
bpmn-io · Sep 20, 2019 · f177a46 · f177a46
1 parent 83e9f05
commit f177a46
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/lib/Viewer.js b/lib/Viewer.js
@@ -479,6 +479,11 @@ Viewer.prototype.getModules = function() {
  * @method Viewer#clear
  */
 Viewer.prototype.clear = function() {
+  if (!this.getDefinitions()) {
+
+    // no diagram to clear
+    return;
+  }
 
   // remove businessObject#di binding
   //

diff --git a/test/spec/ViewerSpec.js b/test/spec/ViewerSpec.js
@@ -1614,6 +1614,25 @@ describe('Viewer', function() {
 
   describe('#clear', function() {
 
+    it('should NOT clear if no diagram', function() {
+
+      // given
+      var viewer = new Viewer({ container: container });
+
+      var eventBus = viewer.get('eventBus');
+
+      var spy = sinon.spy();
+
+      eventBus.on('diagram.clear', spy);
+
+      // when
+      viewer.clear();
+
+      // then
+      expect(spy).not.to.have.been.called;
+    });
+
+
     it('should not throw if diagram is already empty', function() {
 
       // given