Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram Cleared Before First Import #1181

Open
philippfromme opened this issue Sep 3, 2019 · 4 comments
Open

Diagram Cleared Before First Import #1181

philippfromme opened this issue Sep 3, 2019 · 4 comments
Labels
backlog Queued in backlog bug Something isn't working

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Sep 3, 2019 •
edited

Describe the Bug

When importing the first diagram a selection.changed event is fired as the result of clearing even though there is no previously imported diagram.

This bug was introduced by #87.

Steps to Reproduce

  1. Import a diagram

Environment

  • Library version: >=3.4.0
@philippfromme philippfromme added the bug Something isn't working label Sep 3, 2019
@nikku

This comment has been minimized.

Sign in to view
@nikku nikku added the ready Ready to be worked on label Sep 9, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M31 milestone Sep 9, 2019
philippfromme added a commit that referenced this issue Sep 20, 2019
@philippfromme
fix(viewer): do not clear diagram if no diagram to clear
cdbd13f 
Closes #1181
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Sep 20, 2019
@philippfromme philippfromme mentioned this issue Sep 20, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 20, 2019
fake-join bot pushed a commit that referenced this issue Sep 20, 2019
@philippfromme @fake-join
fix(viewer): do not clear diagram if no diagram to clear
f177a46 
Closes #1181
@philippfromme
Copy link
Contributor Author

Closed via #1193

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 22, 2019
@philippfromme
Copy link
Contributor Author

Bug is not fixed by #1193. getDefinitions() will always return definitions on import because they're set just before the check.

@philippfromme philippfromme reopened this Oct 21, 2020
@nikku nikku added the ready Ready to be worked on label Oct 21, 2020
@MaxTru MaxTru removed this from the M31 milestone Oct 25, 2020
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Jan 25, 2021
@nikku
Copy link
Member

nikku commented Jan 25, 2021

Moving this back to backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Queued in backlog bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikku @philippfromme @MaxTru