Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TLBR snapping for non-container elements #1104

Closed
nikku opened this issue Jun 25, 2019 · 7 comments · Fixed by #1108
Closed

Disable TLBR snapping for non-container elements #1104

nikku opened this issue Jun 25, 2019 · 7 comments · Fixed by #1108
Assignees
Milestone

Comments

@nikku
Copy link
Member

nikku commented Jun 25, 2019

Is your feature request related to a problem? Please describe.

The latest release (v4) introduces snapping on all sides, including top, bottom, left and right.
This results in a lot of snapping noise when moving normal flow elements.

Under the assumption that plain flow elements are usually center aligned we could consider removing that feature for these elements.

Describe the solution you'd like

Snap non-container nodes, excluding text annotations only using their mid.

Describe alternatives you've considered

See the noise as a feature (I guess?).

Additional context

See the attached screencast for a demonstration of this issue:

bug

@nikku nikku added this to the M29 milestone Jun 25, 2019
@nikku nikku added the ready Ready to be worked on label Jun 25, 2019
@nikku
Copy link
Member Author

nikku commented Jun 25, 2019

Can we look into this one and see if it would result in a better user experience?

We can always add additional snap points, too if we receive the relevant feedback to do so.

@nikku nikku self-assigned this Jun 26, 2019
@nikku
Copy link
Member Author

nikku commented Jun 26, 2019

I'll have a lookie lookie 👀

nikku added a commit to bpmn-io/diagram-js that referenced this issue Jun 26, 2019
Removing the default TRBL snapping in favor of fine-grained
control in using applications.

Related to bpmn-io/bpmn-js#1104
@barmac
Copy link
Member

barmac commented Jun 27, 2019

I think the solution you proposed makes a lot of sense. It feels more natural to align to the center of another shape, but never to any of the bounds.

kap

@nikku
Copy link
Member Author

nikku commented Jun 27, 2019

I'm struggeling and juggeling with writing test cases for this one in bpmn-js. ⛑️

nikku added a commit that referenced this issue Jun 27, 2019
@nikku
Copy link
Member Author

nikku commented Jun 27, 2019

out qy2aF

Feels way better now and moves the responsibility for special snapping to bpmn-js (and friends).

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Jun 27, 2019
nikku added a commit that referenced this issue Jun 27, 2019
nikku added a commit that referenced this issue Jun 27, 2019
Adds TRBL snapping with containers only.

Closes #1104
@nikku
Copy link
Member Author

nikku commented Jun 27, 2019

@barmac Ready for review via bpmn-io/diagram-js#376 and #1108. Please check it out. For me it feels like another substantial UX improvement.

nikku added a commit to bpmn-io/diagram-js that referenced this issue Jun 27, 2019
Removing the default TRBL snapping in favor of fine-grained
control in using applications.

Related to bpmn-io/bpmn-js#1104
@barmac
Copy link
Member

barmac commented Jun 27, 2019

Closed via #1108

@barmac barmac closed this as completed Jun 27, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 27, 2019
barmac pushed a commit that referenced this issue Jul 2, 2019
Adds TRBL snapping with containers only.

Closes #1104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants