Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting events and gateways makes some elements smaller than normal or to disappear #1294

Closed
vcpablo opened this issue Mar 16, 2020 · 5 comments · Fixed by #1299
Closed

Selecting events and gateways makes some elements smaller than normal or to disappear #1294

vcpablo opened this issue Mar 16, 2020 · 5 comments · Fixed by #1299
Assignees
@nikku
Labels
bug Something isn't working
Milestone
M35

Comments

@vcpablo
Copy link

vcpablo commented Mar 16, 2020 •
edited by nikku

Describe the Bug

Completing direct editing with an empty label resizes the label target to minimum bounds:

capture ZnZ8sj_optimized

This can be reproduced on demo.bpmn.io, too.

Steps to reproduce

  1. Start direct editing on element with external label.
  2. Complete direct editing with empty text

This broke via e4e789b#diff-642682e3de745f747ccb55e702973a89L107.

Describe the Bug

After clicking on an event (of any kind) or a gateway (of any kind) the shapes of the elements change quickly and become smaller and not clickable (the gateway elements even disappear). This bug happened after I upgraded from version 6.3.0 to 6.3.3

Here is an image demonstrating what happens to the quoted elements
image

Steps to Reproduce

  1. Import a BPMN XML to the tool
  2. Click on an element (to select it) which type is: event or gateway

Obs: By selecting the elements using the Lasso Tool, this bug does not happen

Expected Behavior

The elements must not change its shape or disappear when clicked, see example below (screenshot from demo.bpmn.io

image

Environment

  • Browser: Google Chrome Version 80.0.3987.132 (Official Build) (64-bit)
  • OS: MacOS Catalina 10.15.3
  • Library version: 6.3.3
@vcpablo vcpablo added the bug Something isn't working label Mar 16, 2020
@vcpablo vcpablo changed the title Selecting events and gateways makes the elements smaller that normal Selecting events and gateways makes the elements smaller than normal or to disappear Mar 16, 2020
@vcpablo vcpablo changed the title Selecting events and gateways makes the elements smaller than normal or to disappear Selecting events and gateways makes some elements smaller than normal or to disappear Mar 16, 2020
@nikku
Copy link
Member

nikku commented Mar 16, 2020

I cannot reproduce this issue locall as well as on our demo:

capture 81fp5l_optimized

Please spend some time to understand the changes since the upgrade and provide some additional context how you use the toolkit.

@nikku nikku added the help wanted Extra attention is needed label Mar 16, 2020
@nikku nikku closed this as completed Mar 20, 2020
@nikku nikku reopened this Mar 27, 2020
@nikku
Copy link
Member

nikku commented Mar 27, 2020

I am able to reproduce the issue on demo.bpmn.io.

It is not about selecting but about completing direct editing with an empty label. That resizes the element accidentally to the empty labels bounds (width 0px):

capture ZnZ8sj_optimized

Steps to reproduce

  1. Start direct editing on element with external label.
  2. Complete direct editing with empty text

This broke via e4e789b#diff-642682e3de745f747ccb55e702973a89L107.

@nikku nikku removed the help wanted Extra attention is needed label Mar 27, 2020
@nikku
Copy link
Member

nikku commented Mar 27, 2020

Updated the issue description accordingly.

nikku added a commit that referenced this issue Mar 27, 2020
@nikku
fix(modeling): do not resize label target when setting empty label
d28d123 
This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 27, 2020
@nikku nikku mentioned this issue Mar 27, 2020
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 27, 2020
@vcpablo
Copy link
Author

vcpablo commented Mar 29, 2020

Thanks @nikku nice to know you were able to reproduce it.

fake-join bot pushed a commit that referenced this issue Mar 30, 2020
@nikku @fake-join
fix(modeling): do not resize label target when setting empty label
960a085 
This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294
@nikku
Copy link
Member

nikku commented Mar 30, 2020

Closed via #1299.

@nikku nikku closed this as completed Mar 30, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 30, 2020
@nikku nikku added this to the M35 milestone Mar 30, 2020
@nikku nikku mentioned this issue Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Milestone
M35
Development

Successfully merging a pull request may close this issue.

fix(modeling): do not resize label target when setting empty label bpmn-io/bpmn-js
2 participants
@nikku @vcpablo