Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modeling): do not resize label target when setting empty label #1299

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 27, 2020

This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294

This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 27, 2020
@nikku nikku changed the base branch from develop to master March 27, 2020 23:00
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fake-join fake-join bot merged commit 960a085 into master Mar 30, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 30, 2020
@fake-join fake-join bot deleted the 1294-prevent-label-resize branch March 30, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Selecting events and gateways makes some elements smaller than normal or to disappear
2 participants