Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataStoreReference to DataObjectReference replace menu and vice-versa #1372

Closed
azeghers opened this issue Nov 17, 2020 · 4 comments · Fixed by #1382
Closed

Add DataStoreReference to DataObjectReference replace menu and vice-versa #1372

azeghers opened this issue Nov 17, 2020 · 4 comments · Fixed by #1382
Assignees
Labels
enhancement New feature or request

Comments

@azeghers
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In its current state of the DataObjectReference replace menu only contains the collection marker.
It feels empty and out of place.
image

As discussed with @andreasgeier, it has been suggested to make it possible for a DataObjectReference to be switched to a DataStoreReference, and vice-versa.
This will ensure that the menu is always populated with something, at least until the DataObjectInputs/Outputs are handled.

@azeghers azeghers added the enhancement New feature or request label Nov 17, 2020
@azeghers azeghers self-assigned this Nov 17, 2020
@azeghers azeghers added the ready Ready to be worked on label Nov 17, 2020
@azeghers
Copy link
Contributor Author

First draft :

data-object-replace-2020-11-17-1

@andreasgeier

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 18, 2020
@azeghers
Copy link
Contributor Author

Second draft, with some help from Mr. Fromme :
data-object-replace-2020-11-18-1

@andreasgeier

@andreasgeier
Copy link

It looks like you use the top left corner as a reference point when switching between symbols of different sizes. I would try the center of the symbol, otherwise, it would be no longer aligned when it is part of a diagram and connected with lines to other elements.

@andreasgeier
Copy link

The current solution is related to camunda/camunda-modeler#593

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 2, 2020
@fake-join fake-join bot closed this as completed in #1382 Dec 3, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants