-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch between DataStore and DataObject in replace menu #1382
Conversation
d93b2f9
to
c7b32b4
Compare
Are the package-lock.json changes intended? |
// The DataStoreReference element is 14px wider than the DataObjectReference element | ||
// This ensures that they stay centered on the x axis when replaced | ||
if ( | ||
newElement.type === 'bpmn:DataStoreReference' || | ||
newElement.type === 'bpmn:DataObjectReference' | ||
) { | ||
newElement.x = element.x + (element.width - newElement.width) / 2; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
They aren't, but that's what happens when I Do you have insights on this? |
See https://stackoverflow.com/questions/64813775/is-there-any-way-to-fix-package-lock-json-lockfileversion-so-npm-uses-a-specific. Therefore I would not include the |
Please use It also makes sense to stick to @azeghers Can you verify this? |
c7b32b4
to
660348a
Compare
I fought a bit with nvm but I should be on the correct npm version now. |
Which issue does this PR address?
Closes #1372
Acceptance Criteria
Definition of Done