Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when copy Pool #1555

Closed
hungdaica77 opened this issue Dec 23, 2021 · 5 comments
Closed

Error when copy Pool #1555

hungdaica77 opened this issue Dec 23, 2021 · 5 comments
Assignees
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@hungdaica77
Copy link

hungdaica77 commented Dec 23, 2021

Describe the Bug

Duplicate Pool id when copy Pool

Expected Behavior

  1. Create Pool with Task inside Pool
  2. Copy Pool and paste
  3. Export
  4. Import file was exported

fail

<bpmn:process id="Process_17iojvx" isExecutable="false">
    <bpmn:task id="Activity_0mkgwx2" />
  </bpmn:process>
  <bpmn:process id="Process_17iojvx" isExecutable="false">
    <bpmn:task id="Activity_1xz8h8p" />
</bpmn:process>

Environment

  • Browser: [Chrome]
  • OS: [Windows 10]
@hungdaica77 hungdaica77 added the bug Something isn't working label Dec 23, 2021
@MaxTru
Copy link
Contributor

MaxTru commented Jan 3, 2022

I cannot reproduce this using
https://demo.bpmn.io/new

See recording:
duplicatePoolAndSave

Can you please give more detailled steps to reproduce this?

@MaxTru MaxTru added the help wanted Extra attention is needed label Jan 3, 2022
@hungdaica77
Copy link
Author

I cannot reproduce this using https://demo.bpmn.io/new

See recording: duplicatePoolAndSave

Can you please give more detailled steps to reproduce this?

After export. You need import file was exported.

@MaxTru
Copy link
Contributor

MaxTru commented Jan 5, 2022

Ah got it - thanks. I can reproduce this. We will have a look.

@MaxTru MaxTru added spring cleaning Could be cleaned up one day backlog Queued in backlog and removed help wanted Extra attention is needed labels Jan 5, 2022
@marstamm marstamm self-assigned this Jan 17, 2022
@marstamm
Copy link
Contributor

Root Cause

When morphing the Process into a Collaboration, the ID get's unclaimed.

moddle.ids.unclaim(rootElementBo.id);

With camunda/camunda-modeler#1410, we keep the IDs when copying Elements, so we create the process with the same ID again.

Solution Sketch
Determine if it makes sense to unclaim IDs when the root changes but nothing is deleted and either:

  • Remove the code that unclaims the ID
  • Ensure the ID is re-claimed once the new participant with a processRefis created

marstamm added a commit that referenced this issue Jan 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Jan 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 18, 2022
fake-join bot pushed a commit that referenced this issue Jan 19, 2022
@MaxTru
Copy link
Contributor

MaxTru commented Jan 19, 2022

Closed via #1578

@MaxTru MaxTru closed this as completed Jan 19, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 19, 2022
barmac pushed a commit that referenced this issue Jan 24, 2022
barmac pushed a commit that referenced this issue Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Development

No branches or pull requests

3 participants