Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conditional start event on parent change #778

Closed
philippfromme opened this issue Apr 3, 2018 · 3 comments
Closed

Update conditional start event on parent change #778

philippfromme opened this issue Apr 3, 2018 · 3 comments
Assignees
@smbea
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Apr 3, 2018 •
edited by barmac
Loading

On parent change updates are necessary:

  • event subprocess -> root - variableEvent property must be deleted

foobar
@philippfromme philippfromme added the backlog Queued in backlog label Apr 3, 2018
@nikku
Copy link
Member

nikku commented Apr 13, 2018

This must be implemented in camunda-bpmn-moddle.

@nikku nikku added the enhancement New feature or request label Apr 13, 2018
@barmac barmac added the good first issue Good for newcomers label Sep 1, 2021
@barmac
Copy link
Member

barmac commented Sep 2, 2021

The camunda:initiator removal applies to all start events. Let's have it in a separate issue.

@barmac barmac mentioned this issue Sep 2, 2021
Closed
@smbea smbea self-assigned this Sep 6, 2021
@smbea smbea added in progress Currently worked on and removed backlog Queued in backlog labels Sep 6, 2021 — with bpmn-io-tasks
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 6, 2021
@smbea
fix(moddle): remove variableEvents when StartEvent parent changes
d9e381c 
- remove variableEvents when conditional StartEvent is moved out of event subProcess

Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 6, 2021
@smbea
fix(moddle): remove variableEvents when StartEvent parent changes
4a2b45a 
- remove variableEvents when conditional StartEvent is moved out of event subProcess

Related to bpmn-io/bpmn-js#778

fix: update eventDefinitions when StartEvent parent changes

- Remove direct access to property
- Modify copy of eventDefinitions and update it in the businessObject

Related to bpmn-io/bpmn-js#778

refactor: cleaner variable declaration
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 6, 2021
@smbea
test(variableEvents): add missing test case
0b92508 
- Test case for when conditional startEvent is moved from an event subProcess to another

Related to bpmn-io/bpmn-js#778
@smbea smbea mentioned this issue Sep 6, 2021
Merged
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 6, 2021
@smbea
fix: change approach to updating eventDefinitions
fcfe7ac 
- Remove direct access to eventDefinitions objects
- Create and modify a copy of each definitions using `bpmnFactory.create` and ` moddleCopy.copyElement`

Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 6, 2021
@smbea
refactor: small changes for consistency purposes
607ebd8 
- Changes in regards to spacing, function declaration, and `if` organization
Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 6, 2021
@smbea
test: Add more eventDefinitions test diagram
209dc0c 
- Update test bmpn diagram to have more than one eventDefinition for the conditional startEvent

Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 7, 2021
@smbea
refactor: clean up code
166287c 
- Refactor in `postExecute` hook for cleaner and more efficient code

Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 7, 2021
@smbea
fix: update conditions in which property is removed
84336c1 
- Property is now removed when: `startEvent` has `eventDefinitions` with `variableEvents` and has is not part of an event `subProcess`

Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 7, 2021
@smbea
test: add missing test case
4a1ec7e 
- Add test case for when event with the property is created outside an event subprocess

Related to bpmn-io/bpmn-js#778
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 8, 2021
@smbea
fix: update conditions in which property is removed
518810e 
- Property is now removed when: `startEvent` has `eventDefinitions` with `variableEvents` and has is not part of an event `subProcess`

Related to bpmn-io/bpmn-js#778

test: add missing test case

- Add test case for when event with the property is created outside an event subprocess

Related to bpmn-io/bpmn-js#778

refactor: cleanup test case code

- Optimize variable declaration
smbea added a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 8, 2021
@smbea
fix(behaviour): update the parent for both 'create' and 'move' events
fd6efd0 
- newParent was updated to consider the 'create' event when there is no newParent or oldParent, just a single parent

Related to bpmn-io/bpmn-js#778
barmac pushed a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 9, 2021
@smbea @barmac
feat: remove variableEvents when StartEvent is outside of event subpr…
af2ad76 
…ocess

- remove variableEvents when conditional StartEvent is moved out of event subProcess

Related to bpmn-io/bpmn-js#778
barmac pushed a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 9, 2021
@smbea @barmac
feat: remove variableEvents when StartEvent is outside of event subpr…
5b9e22e 
…ocess

- remove variableEvents when conditional StartEvent is moved out of event subProcess

Related to bpmn-io/bpmn-js#778
barmac pushed a commit to camunda/camunda-bpmn-moddle that referenced this issue Sep 9, 2021
@smbea @barmac
feat: remove variableEvents for StartEvent outside of EventSubProcess
19ba79a 
- remove variableEvents when conditional StartEvent is moved out of event subProcess

Related to bpmn-io/bpmn-js#778
@smbea smbea added fixed upstream Requires integration of upstream change in progress Currently worked on and removed in progress Currently worked on fixed upstream Requires integration of upstream change labels Sep 9, 2021 — with bpmn-io-tasks
@smbea smbea added the fixed upstream Requires integration of upstream change label Sep 9, 2021
@smbea smbea removed the in progress Currently worked on label Sep 9, 2021 — with bpmn-io-tasks
@barmac
Copy link
Member

barmac commented Sep 15, 2021

This belongs to camunda/camunda-modeler, but cannot be transferred because of different organizations.

@barmac barmac closed this as completed Sep 15, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikku @philippfromme @smbea @barmac