Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy & paste: I can mutate the copied business object after copying #798

Closed
philippfromme opened this issue May 22, 2018 · 4 comments · Fixed by #1707
Closed

Copy & paste: I can mutate the copied business object after copying #798

philippfromme opened this issue May 22, 2018 · 4 comments · Fixed by #1707
Labels
bug Something isn't working modeling spring cleaning Could be cleaned up one day

Comments

@philippfromme
Copy link
Contributor

Hint: This is due to the business object being copied by reference.
@philippfromme philippfromme added the bug Something isn't working label May 22, 2018
@nikku nikku added modeling backlog Queued in backlog labels May 24, 2018
nikku pushed a commit that referenced this issue May 24, 2018
@philippfromme @nikku
test(copy-paste): verify broken copy on businessObject mutation
3047751 
Related to #798
@ghost ghost assigned nikku May 24, 2018
@ghost ghost added in progress Currently worked on and removed backlog Queued in backlog labels May 24, 2018
nikku pushed a commit that referenced this issue May 24, 2018
@philippfromme @nikku
test(copy-paste): verify broken copy on businessObject mutation
7af7920 
Related to #798
@nikku nikku removed their assignment May 24, 2018
@nikku nikku added backlog Queued in backlog and removed in progress Currently worked on labels May 24, 2018
philippfromme added a commit that referenced this issue Nov 15, 2019
@philippfromme
chore(copy-paste): add failing test case verifying #798
1716c50 
Failing test case was removed during refactoring.

Related to #798.
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Nov 15, 2019
@philippfromme philippfromme mentioned this issue Nov 15, 2019
Merged
@philippfromme philippfromme added backlog Queued in backlog and removed in progress Currently worked on labels Nov 18, 2019 — with bpmn-io-tasks
barmac pushed a commit that referenced this issue Nov 19, 2019
@philippfromme @barmac
chore(copy-paste): add failing test case verifying #798
a52434f 
Failing test case was removed during refactoring.

Related to #798.
barmac pushed a commit that referenced this issue Nov 19, 2019
@philippfromme @barmac
chore(copy-paste): add failing test case verifying #798
6724b4f 
Failing test case was removed during refactoring.

Related to #798.
nikku pushed a commit that referenced this issue Nov 19, 2019
@philippfromme @nikku
chore(copy-paste): add failing test case verifying #798
ec13d8e 
Failing test case was removed during refactoring.

Related to #798.
@philippfromme philippfromme mentioned this issue Nov 21, 2019
Merged
@yT0n1
Copy link

yT0n1 commented Dec 18, 2019

What is the ETA of a fix for this bug?

@nikku
Copy link
Member

nikku commented Dec 18, 2019

There is none.

If you'd like to speed things up, file a pull request that addresses the issue.

@nikku
Copy link
Member

nikku commented Dec 18, 2019

Add your 👍 on the issue to indicate your interest in it being fixed.

@yT0n1
Copy link

yT0n1 commented Dec 18, 2019

Ok, we will discuss what makes sense for us at chor-js. Right now we are moving from bpmn-js version 3.4.3 to 6.1. I wanted to avoid having to potentially update our copypast fixes twice in case more changes were planed soon.

@philippfromme philippfromme removed their assignment Oct 27, 2020
@nikku nikku mentioned this issue Aug 11, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels Aug 11, 2022
nikku added a commit that referenced this issue Aug 11, 2022
@nikku
feat(copy-paste): clone element on copy
e6f448d 
Ensures copy is unaffected by edit operations after copy.

Closes #798
@nikku nikku mentioned this issue Aug 12, 2022
Closed
4 tasks
nikku added a commit that referenced this issue Aug 13, 2022
@nikku
feat(copy-paste): clone element on copy
556c0d5 
Ensures copy is unaffected by edit operations after copy.

Closes #798
@nikku nikku added the spring cleaning Could be cleaned up one day label Aug 15, 2022
nikku added a commit that referenced this issue Aug 15, 2022
@nikku
feat(copy-paste): clone element on copy
5d19eef 
Ensures copy is unaffected by edit operations after copy.

Closes #798
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 16, 2022
@fake-join fake-join bot closed this as completed in #1707 Aug 16, 2022
fake-join bot pushed a commit that referenced this issue Aug 16, 2022
@nikku @fake-join
feat(copy-paste): clone element on copy
ab6db7b 
Ensures copy is unaffected by edit operations after copy.

Closes #798
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working modeling spring cleaning Could be cleaned up one day
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clone on copy bpmn-io/bpmn-js
3 participants
@nikku @yT0n1 @philippfromme