Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modeling): attach shapes with labels on paste #1208

Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix(modeling): attach shapes with labels on paste #1208

merged 1 commit into from
Oct 7, 2019

Conversation

oguzeroglu
Copy link
Contributor

@oguzeroglu oguzeroglu commented Oct 2, 2019 •
edited
Loading

Closes #1204

Related to bpmn-io/diagram-js#413

This also fixes: #1205 however will do another PR for that issue to commit some tests.

Kapture 2019-10-02 at 14 44 51

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 2, 2019
@oguzeroglu oguzeroglu changed the title fix(CreateBoundaryEventBehavior): attach shapes with labels on paste [WIP] fix(CreateBoundaryEventBehavior): attach shapes with labels on paste Oct 2, 2019
@oguzeroglu oguzeroglu changed the title [WIP] fix(CreateBoundaryEventBehavior): attach shapes with labels on paste fix(CreateBoundaryEventBehavior): attach shapes with labels on paste Oct 2, 2019
@oguzeroglu oguzeroglu mentioned this pull request Oct 2, 2019
Merged
@barmac
Copy link
Member

barmac commented Oct 2, 2019

fix(CreateBoundaryEventBehavior) => fix(modeling)

@barmac
Copy link
Member

barmac commented Oct 2, 2019

problem
This requires a fix.

barmac
barmac requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments + discussion.

@oguzeroglu oguzeroglu changed the title fix(CreateBoundaryEventBehavior): attach shapes with labels on paste fix(modeling): attach shapes with labels on paste Oct 2, 2019
@oguzeroglu oguzeroglu force-pushed the 1204-allow-create-on-attach-shapes-with-labels branch 2 times, most recently from 4aad63f to 2a6fd81 Compare October 2, 2019 15:45
@oguzeroglu oguzeroglu force-pushed the 1204-allow-create-on-attach-shapes-with-labels branch from 2a6fd81 to 8a9fdfd Compare October 2, 2019 15:54
@oguzeroglu
Copy link
Contributor Author

@barmac Ready!

sdfdsf

asd

@barmac barmac merged commit 69881bd into master Oct 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 7, 2019
@fake-join fake-join bot deleted the 1204-allow-create-on-attach-shapes-with-labels branch October 7, 2019 08:41
@barmac barmac mentioned this pull request Oct 7, 2019
Closed
@barmac barmac restored the 1204-allow-create-on-attach-shapes-with-labels branch October 7, 2019 08:56
@barmac
Copy link
Member

barmac commented Oct 7, 2019

Accidentally merged to master while it depends on a future minor release of diagram-js.

@barmac barmac mentioned this pull request Oct 7, 2019
Merged
@oguzeroglu oguzeroglu mentioned this pull request Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac requested changes

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oguzeroglu @barmac