Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermediate Events with labels cannot be pasted as Boundary Events #1204

Closed
oguzeroglu opened this issue Sep 27, 2019 · 2 comments · Fixed by #1214
Closed

Intermediate Events with labels cannot be pasted as Boundary Events #1204

oguzeroglu opened this issue Sep 27, 2019 · 2 comments · Fixed by #1214
Assignees
@oguzeroglu @barmac
Labels
bug Something isn't working
Milestone
M31

Comments

@oguzeroglu
Copy link
Contributor

Describe the Bug

If an intermediate event has a label, it cannot be pasted as a boundary event. See the GIF:
bug

Steps to Reproduce

  1. Create an intermediate event with label
  2. Copy the event
  3. Try to paste it over a Task, as a boundary event.

Expected Behavior

Intermediate Event can be pasted as Boundary Event

Environment

  • OS: Mac OS Mojave 10.14.5
  • Library version: v5.0.5
@oguzeroglu oguzeroglu mentioned this issue Sep 27, 2019
Merged
@oguzeroglu oguzeroglu added the bug Something isn't working label Sep 27, 2019
@philippfromme philippfromme added the ready Ready to be worked on label Sep 27, 2019
@oguzeroglu oguzeroglu self-assigned this Sep 30, 2019
@oguzeroglu oguzeroglu added in progress Currently worked on and removed ready Ready to be worked on labels Sep 30, 2019 — with bpmn-io-tasks
oguzeroglu pushed a commit that referenced this issue Oct 2, 2019
fix(CreateBoundaryEventBehavior): attach shapes with labels on paste
3533e8e 
Closes #1204
@oguzeroglu oguzeroglu mentioned this issue Oct 2, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 2, 2019
oguzeroglu pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 2, 2019
feat(create): allow attachment of shapes with labels on creation
2479f60 
Related to bpmn-io/bpmn-js#1204
oguzeroglu pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 2, 2019
feat(create): allow attachment of shapes with labels on creation
94e8379 
Related to bpmn-io/bpmn-js#1204
oguzeroglu pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 2, 2019
feat(create): allow attachment of shapes with labels on creation
5d6e598 
Related to bpmn-io/bpmn-js#1204
oguzeroglu pushed a commit that referenced this issue Oct 2, 2019
fix(modeling): attach shapes with labels on paste
4aad63f 
Closes #1204
oguzeroglu pushed a commit that referenced this issue Oct 2, 2019
fix(modeling): attach shapes with labels on paste
2a6fd81 
Closes #1204
oguzeroglu pushed a commit that referenced this issue Oct 2, 2019
fix(modeling): attach shapes with labels on paste
8a9fdfd 
Closes #1204
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Oct 7, 2019
@fake-join
feat(create): allow attachment of shapes with labels on creation
a4ea387 
Related to bpmn-io/bpmn-js#1204
barmac pushed a commit that referenced this issue Oct 7, 2019
@barmac
fix(modeling): attach shapes with labels on paste
69881bd 
Closes #1204
@barmac
Copy link
Member

barmac commented Oct 7, 2019

Closed via #1208

@barmac barmac closed this as completed Oct 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot reopened this Oct 7, 2019
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 7, 2019
@barmac barmac mentioned this issue Oct 7, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 7, 2019
barmac pushed a commit that referenced this issue Oct 7, 2019
@barmac
feat(modeling): attach shapes with labels on paste
3be02ff 
Closes #1204
barmac pushed a commit that referenced this issue Oct 7, 2019
@barmac
feat(modeling): attach shapes with labels on paste
68a6d48 
Closes #1204
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 7, 2019
@philippfromme
Copy link
Contributor

Will be properly fixed through #1203

@philippfromme philippfromme reopened this Oct 13, 2019
philippfromme added a commit that referenced this issue Oct 13, 2019
@philippfromme
fix(modeling): copy and paste boundary events
6baa0dd 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
Closes #1202
Closes #1204
Closes #1205
philippfromme added a commit that referenced this issue Oct 13, 2019
@philippfromme
feat(modeling): copy and paste boundary events
2e27d74 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
Closes #1202
Closes #1204
Closes #1205
@nikku nikku added this to the M31 milestone Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzeroglu oguzeroglu

@barmac barmac

Labels
bug Something isn't working
Milestone
M31
Development

Successfully merging a pull request may close this issue.

Allow to attach shapes with labels on paste bpmn-io/bpmn-js
4 participants
@nikku @philippfromme @oguzeroglu @barmac