Resize Empty Text Annotations on Complete #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
nikku
reviewed
Mar 10, 2020
| @@ -104,11 +104,6 @@ export default function UpdateLabelHandler(modeling, textRenderer) { | |||
|
|
|||
| var text = getLabel(label); | |||
|
|
|||
| // don't resize without text | |||
There was a problem hiding this comment.
Do you know why we added this in the first place? Is it due to some label related legacy?
1 task
vzan2012
pushed a commit
to vzan2012/bpmn-js
that referenced
this pull request
May 28, 2021
vzan2012
pushed a commit
to vzan2012/bpmn-js
that referenced
this pull request
May 28, 2021
* setting minimum bounds and resize constraints moved to ResizeBehavior Related to bpmn-io#1290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bpmn-io/diagram-js-direct-editing#12