Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty text-box does not resize #12

Closed
1 task
barmac opened this issue Apr 4, 2019 · 4 comments
Closed
1 task

Empty text-box does not resize #12

barmac opened this issue Apr 4, 2019 · 4 comments
Assignees
@philippfromme
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Milestone
M35

Comments

@barmac
Copy link
Member

barmac commented Apr 4, 2019 •
edited by nikku

Describe the Bug

Element bounds are unstable when resizing a text field created by direct editing.

Steps to Reproduce

  • Create a text annotation.
  • Open direct editing of the created element.
  • Without typing, resize the text input.
  • Complete direct editing (with no text entered)
  • The box bounds jump back to the original size

Expected Behavior

  • Text annotation should be resized to new bounds

Screencast

bug

Environment

Please complete the following information:

  • Browser: Chromium (Camunda Modeler)
  • OS: MacOS
  • Library version: 1.14.1
@barmac barmac added the bug Something isn't working label Apr 4, 2019
@nikku
Copy link
Member

nikku commented Apr 4, 2019

What is your expected behavior? It is not clear to me, looking at the screen cast alone.

@barmac
Copy link
Member Author

barmac commented Apr 4, 2019

I added a text description.

@nikku
Copy link
Member

nikku commented Apr 8, 2019

Got it, thanks for clarifying. 👍

@nikku nikku added the backlog Queued in backlog label Apr 8, 2019
@nikku nikku changed the title Unstable resize behaviour Empty text-box does not resize Apr 8, 2019
@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label Feb 28, 2020
@philippfromme philippfromme added in progress Currently worked on and removed backlog Queued in backlog labels Mar 10, 2020 — with bpmn-io-tasks
@philippfromme philippfromme self-assigned this Mar 10, 2020
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Mar 10, 2020
@philippfromme
fix(label-editing): resize empty text annotations on complete
e4e789b 
Related to bpmn-io/diagram-js-direct-editing#12
@philippfromme philippfromme mentioned this issue Mar 10, 2020
Merged
@nikku
Copy link
Member

nikku commented Mar 11, 2020

Actually a bug downstream, fixed via bpmn-io/bpmn-js#1290.

@nikku nikku closed this as completed Mar 11, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Mar 11, 2020
@nikku nikku added this to the M35 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Milestone
M35
Development

No branches or pull requests
4 participants
@nikku @philippfromme @pinussilvestrus @barmac