-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v14.1.0 #1974
chore: release v14.1.0 #1974
Conversation
The duplicated commit is due to my commit amendment on |
1c11c45
to
483c056
Compare
OK duplicated commit message is fixed now. |
Regarding this PR, I can see a couple of potential improvements:
|
@barmac I do not understand this:
For us we regularily upgrade our dependencies, fixing issues. How is this being ignored? |
CHANGELOG.md
Outdated
## [14.0.1](https://github.com/bpmn-io/bpmn-js/compare/v14.0.0...v14.0.1) (2023-10-12) | ||
|
||
|
||
### Bug Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to adjust our changelogs? I'd advocate not to do it (just yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can:
- (try to) Create a custom changelog template for
release-please
which resembles our current practice. - Accept the default
release-please
template for this and future updates. - Manually adjust the automatic changelog updates so that we stick to our current practice (until (1) is implemented).
I am OK with (2) as long as the default release-please
template is good enough. I don't think our current changelog template is better than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like our existing template, because it is compact, and meaningful.
What you propose hides a major feature (cf. #557).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this clearly shows a gap in release-please
. A new feature (local spacetool) may never be a patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new feature (local spacetool) may never be a patch.
I totally agree with you. That's why we need to be extra careful with commit messages if we want automation. So it's no more "oh you labeled is as patch-releasable, but it's a feature in fact". Or we review automation result manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would make more sense to do sth like:
deps: update diagram-js to v12.2.0
feat: support local space tool
Closes #758
https://github.com/googleapis/release-please#what-if-my-pr-contains-multiple-fixes-or-features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this. If we want automation, then we want to be super strict about our commits. If we think we can be, then let's try it :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm custom changelog seems to be doable, but I couldn't find a way to do it in the github action:
I did not dive deep though.
I will check if we can easily include |
This is doable via https://github.com/google-github-actions/release-please-action#overriding-the-changelog-sections |
I've created some adjustments and will push them to test. |
efe9885
to
2f5733e
Compare
OK it's applied in the PR. WDYT? |
According to https://github.com/google-github-actions/release-please-action/issues/838, we cannot fully customize the changelog at the moment, if we stick to the release-please-action. I'd rather not switch to the CLI tool though. @nikku |
We can also try out |
2f5733e
to
dd6e148
Compare
It looks like a step back to me ;) WDYT @nikku ? |
Let's discuss with the team. I'm not a fan of overly verbose changelogs, and I also think a little bit of updating (cross-checking what we released) does not hurt. The original ones the tool generated can trivially be grouped to fit our own CHANGELOG style, and we can learn how to write better commit messages (combine But if I'm the only one in favor of keeping our changelogs, then I'm happy to adjust, too. |
In terms of compactness I obviously prefer the |
37e37a3
to
a38eb82
Compare
a38eb82
to
799f746
Compare
🤖 Release is at https://github.com/bpmn-io/bpmn-js/releases/tag/v14.1.0 🌻 |
🤖 I have created a release beep boop
14.1.0
FEAT
: ensure lanes aren't resized when using space tool in Integrate Local Space Tool #1972DOCS
: update translations for v14.0.0 by @bpmn-io-bot in docs: update translations for v14.0.0 #1948This PR was generated with Release Please. See documentation.