Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choreography activity participantRef(s) #59

Closed
jan-ladleif opened this issue Nov 29, 2018 · 4 comments
Closed

Choreography activity participantRef(s) #59

jan-ladleif opened this issue Nov 29, 2018 · 4 comments
Labels
bug Something isn't working export import pr welcome We rely on a community contribution to improve this.

Comments

@jan-ladleif
Copy link

Hi everyone,

we're currently working on a BPMN 2.0 choreography diagram modeler (chor-js, chor-js-demo) based on bpmn-js and bpmn-moddle. We've noticed some inconsistencies regarding the name of the participantRefs association on Choreography Activity (and Conversation Node).

Apparently, depending on where you look, the trailing s is sometimes missing:

participantRef participantRefs (with s)
BPMN 2.0 XSD BPMN 2.0 CMOF
Signavio BPMN 2.0 standard document (in the text)
Eclipse BPMN2 Modeler bpmn-moddle

Our current plan is to be able to import both versions, and export the participantRef version for compatibility with Signavio and the Eclipse BPMN2 Modeler.

Suggestion: We are not aware of any tool using the participantRefs version found in the CMOF, so the workarounds could be scraped if the association was renamed to participantRef in bpmn-moddle as well.

@nikku
Copy link
Member

nikku commented Nov 29, 2018

Thanks for reporting ❤️.

This library is meant to be a general purpose library for validating and consuming and producing BPMN 2.0 XML documents. If the schema contains a bug, i.e. is unable to consume or produce valid BPMN 2.0 XML (or produce it) we must fix this issue.

The namings of variables are not set in stone, in fact they are solely the result of generating the bpmn.json meta model from the BPMN 2.0 CMOF. We already address numerous issues during the automated conversion process, inspect them here.

Could you share valid diagrams that are not handled correctly as of now? That allows us to do further investigation.

Please consider creating a pull request that contains the relevant test cases for round-tripping a valid BPMN 2.0 diagram using our library (cf. roundtrip tests). This usually speeds up our report-to-fix cycle times 😉. Starting based of an existing PR I am happy to improve the test coverage and implement the actual fix in our conversion process.

@nikku nikku added bug Something isn't working export import pr welcome We rely on a community contribution to improve this. labels Nov 29, 2018
@nikku
Copy link
Member

nikku commented Nov 29, 2018

We're currently working on a BPMN 2.0 choreography diagram modeler (chor-js, chor-js-demo) based on bpmn-js and bpmn-moddle.

I am personally super exited about this one, by the way!

@jan-ladleif
Copy link
Author

jan-ladleif commented Nov 30, 2018

Thank you for the quick reply! I've prepared a branch locally but for some reason cannot seem to push it (permission denied). Are there any restrictions on the repo?

/edit: Nevermind, figured it out. I'll post a PR soon.

@nikku
Copy link
Member

nikku commented Nov 30, 2018

Closed via 0f84699.

@nikku nikku closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working export import pr welcome We rely on a community contribution to improve this.
Development

No branches or pull requests

2 participants