Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for tolerance with "participantRef" #45

Closed
yT0n1 opened this issue Nov 29, 2018 · 2 comments
Closed

Allow for tolerance with "participantRef" #45

yT0n1 opened this issue Nov 29, 2018 · 2 comments

Comments

@yT0n1
Copy link
Collaborator

yT0n1 commented Nov 29, 2018

Some files from external sources might contain "participantRef" instead of "participantRefs".

The standard is unclear regarding this. See pages 322 and 364 in the standard. BPMN20.cmof and Semantic.xsd differ in that regard (https://www.omg.org/spec/BPMN/#docs-normative-supporting). Import should support both options, export should support "participantRef" to be compatible with eclipse and Signavio

@jan-ladleif
Copy link
Member

Here's the relevant replacement snippet from another project of mine for the import:

// Preprocessing: Signavio exports <participantRef> elements instead of
// <participantRefs> (notice the missing 's'). The metamodel expects the s, though.
xml = xml.replace(/<(\/)?(bpmn2:|bpmn:)?participantRef>/g, '<$1$2participantRefs>');

@jan-ladleif
Copy link
Member

This has been fixed in bpmn-moddle with bpmn-io/bpmn-moddle#60

We should just update and use the participantRef variant now. There are probably no models around that use the version with the s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants