Specialize popup menu classes (with prefix)

[smbea]

What should we do?

Investigate if other djs elements maintain specialized prefixed classes (eg: djs-popup-...) at all times, and decide if we should follow this for the popup menu.

Why should we do it?

To have a clear understand of how djs elements should be implemented and to keep consistency with other djs elements.

[smbea]

After some investigation, I found that djs elements mostly follow the principle of prefixing the classes but there are some exceptions:

Common classes shared by multiple elements: .entry, .open
Some other classes used for a single element:

• .new-parent
• .highlighted-entry
• .separator
• .two-column
• .floating

I feel like the exceptions are few also because we haven't added many complex elements yet.

In popup menu, we have some classes that may be more generic and therefore cause more collision, like .name, .title, .results. I think we should keep .entry anyway to be consistent.

To move forward, we can:

1. Ignore this for now. Like Nico said, we haven't had any complaints yet.
   1.1 This means we integrate it faster but might also mean revisiting this in the future (if needed)
2. Prefix the popup menu classes added
   2.1. Since this causes more breaking changes, does it mean we need another major release?

cc @nikku @barmac

[nikku]

Since this causes more breaking changes, does it mean we need another major release?

If we go for this (and follow up soon), let's bake it into a 11.x minor release.

11.x has not been adopted to date.

[nikku]

You could also mark 11.x as next on npm to be sure.

==> diagram-js@10.0.0 is now latest again.

[smbea]

Then I vote we do it now, since we have to do a release anyway. It should be fairly quick to change the classes to djs-popup-....