Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize popup menu classes #704

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Specialize popup menu classes #704

merged 2 commits into from
Nov 21, 2022

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Nov 21, 2022

Closes #703

I didn't add anything to breaking changes because it is already included with:

HTML structure and CSS classes of the popup menu changed in the context of #687. Ensure alignment with the new structure in your custom implementation.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 21, 2022
@smbea smbea marked this pull request as draft November 21, 2022 18:13
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 21, 2022
font-weight: 500;
color: var(--popup-entry-title-color);
padding-left: 0;
}

.djs-popup .djs-popup-body .entry-icon {
.djs-popup .djs-popup-body .djs-popup-entry-icon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.djs-popup .djs-popup-body .djs-popup-entry-icon {
.djs-popup-entry-icon {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops had missed that one

@smbea smbea marked this pull request as ready for review November 21, 2022 18:48
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 21, 2022
@nikku nikku merged commit 8044f11 into develop Nov 21, 2022
@nikku nikku deleted the 703-specialize-classes branch November 21, 2022 21:53
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specialize popup menu classes (with prefix)
2 participants