Improve entries apis: Context Pad, Palette, Popup Menu #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
428-improve-entries-apis
branch
5 times, most recently
from
96651f3
to
065ddca
Compare
There can be multiple providers and each of them can add, modify and remove entries in the order of registration.
barmac
force-pushed
the
428-improve-entries-apis
branch
from
065ddca
to
0bfe1c1
Compare
barmac
force-pushed
the
428-improve-entries-apis
branch
from
c0121e5
to
2d74917
Compare
bpmn-io-tasks
bot
added
needs review
|
This can be tested with https://github.com/barmac/bpmn-js-reworked-replace-menu |
This was referenced Nov 8, 2019
nikku
reviewed
Nov 11, 2019
barmac
force-pushed
the
428-improve-entries-apis
branch
from
2d74917
to
e1fece3
Compare
|
@nikku I updated the PR in accordance with the comments. |
This allows us to do the following:
```
const fooEvent = eventBus.createEvent({
type: 'foo'
});
eventBus.fire(fooEvent);
```
I assume this would already work, but it did not until now.
|
I've sketched how to register providers using the eventBus here. |
|
@nikku Ready for another round. |
nikku
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #428
Note: This breaks multiple test cases in
bpmn-js, but all of the failures base on checking the internals. I'll prepare a fix for that.