Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(canvas): allow IDs for #scrollToElement #590

Merged
merged 1 commit into from
Nov 15, 2021
Merged

fix(canvas): allow IDs for #scrollToElement #590

merged 1 commit into from
Nov 15, 2021

Conversation

marstamm
Copy link
Contributor

closes #589

@marstamm marstamm requested a review from a team November 15, 2021 09:55
@marstamm marstamm self-assigned this Nov 15, 2021
@marstamm marstamm requested review from philippfromme and smbea and removed request for a team November 15, 2021 09:55
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 15, 2021
nikku
nikku approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thank you :clap

@nikku nikku merged commit 63536e4 into master Nov 15, 2021
@nikku nikku deleted the 589-scroll-to-element-id branch November 15, 2021 11:52
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marstamm @nikku