Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup-menu): display even if no cursor is passed to open #654

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Jun 28, 2022

Previously, the popup menu would be stuck with visibility: hidden.

@barmac barmac requested review from a team, Skaiir and marstamm and removed request for a team June 28, 2022 12:56
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 28, 2022
@barmac barmac requested review from a team, philippfromme, pinussilvestrus, nikku and smbea and removed request for Skaiir, marstamm, a team and pinussilvestrus June 28, 2022 12:56
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Visibility shall not depend on actual cursor position.

@fake-join fake-join bot merged commit a68b7c6 into master Jun 29, 2022
@fake-join fake-join bot deleted the display-popup-menu-even-if-no-cursor-is-provided branch June 29, 2022 06:39
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants