Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of Input Expression/Name and Label #346

Closed
ingorichtsmeier opened this issue Apr 11, 2018 · 5 comments
Closed

Change order of Input Expression/Name and Label #346

ingorichtsmeier opened this issue Apr 11, 2018 · 5 comments
Assignees

Comments

@ingorichtsmeier
Copy link
Contributor

The Label can technically be omitted. But if you add an input expression "guests with children?", which looks fine on the first glance, (see this table: https://github.com/ingorichtsmeier/dmn-test-tool/blob/master/dmn-excel-tester/src/test/resources/exampleEvaluation/modeler12_1.dmn) you will get an error when you evaluate it: https://github.com/ingorichtsmeier/dmn-test-tool/blob/master/dmn-excel-tester/src/test/java/com/camunda/consulting/dmn_excel_tester/example/ExampleEvaluations.java#L169-L187

So, the Label is most important for business users and should be entered first. Then you could add an input expression for evaluation (or generate it on the fly as the simulator (https://camunda.com/de/dmn/simulator/) or the dmn-test-tool (https://github.com/ingorichtsmeier/dmn-test-tool) do.

Both, the Label and Input Expression should be visible all the time.

@ingorichtsmeier
Copy link
Contributor Author

ingorichtsmeier commented Apr 11, 2018

Addition: I never used the input variable since we support DMN.

Maybe you could switch the display of the inputVariable with the Input Expression?

@nikku
Copy link
Member

nikku commented Apr 12, 2018

Could you attach a screenshot providing a little bit more context?

@ingorichtsmeier
Copy link
Contributor Author

This table won't work:

grafik

This table will work, but you have to use the context menu to inspect the input expression:

grafik

This table looks nice, but I have never used the input variable before:

grafik

@ingorichtsmeier
Copy link
Contributor Author

OK, lets keep the focus of this ticket on the order of the labels of the pop-up dialogues. (as the title of the ticket says)

The user should enter the input/output label first

and then the input expression/output name.

@ghost ghost assigned nikku Apr 17, 2018
@ghost ghost added the in progress Currently worked on label Apr 17, 2018
@nikku nikku added backlog Queued in backlog and removed in progress Currently worked on labels Apr 17, 2018
@ghost ghost assigned barmac Feb 28, 2019
@ghost ghost added needs review Review pending and removed backlog Queued in backlog labels Feb 28, 2019
@nikku
Copy link
Member

nikku commented Mar 7, 2019

Closed via #395.

@nikku nikku closed this as completed Mar 7, 2019
@ghost ghost removed the needs review Review pending label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants