Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can remove the aggregation operator from hit policy COLLECT using the dropdown #389

Closed
sebwarnke opened this issue Jan 18, 2019 · 1 comment · Fixed by #420
Closed

I can remove the aggregation operator from hit policy COLLECT using the dropdown #389

sebwarnke opened this issue Jan 18, 2019 · 1 comment · Fixed by #420
Assignees
@barmac
Labels
Decision Table enhancement New feature or request pr welcome We rely on a community contribution to improve this.
Milestone
M32

Comments

@sebwarnke
Copy link

sebwarnke commented Jan 18, 2019 •
edited by barmac
Loading

Is your feature request related to a problem? Please describe.
dmn

Currently, there is no dropdown button to clear aggregation operator for COLLECT hit policy. User has to manually erase the operator to achieve this.

  • To set an aggregation operator to hit policy collect I can use a dropdown to select the operator from.
  • To reset to hit policy COLLECT without aggregation operators I cannot select an empty element in the dropdown but I have to remove the operator by backspacing the editable selected element.

Describe the solution you'd like
Add <none> or equivalent button in the dropdown to remove aggregation for COLLECT hit policy.
@barmac barmac added enhancement New feature or request backlog Queued in backlog Decision Table pr welcome We rely on a community contribution to improve this. labels Feb 28, 2019
@barmac
Copy link
Member

barmac commented Feb 28, 2019 •
edited
Loading

I added a GIF file that shows the problem and also included more details in solution description.

Please feel free to prepare a pull request with a solution. Here you can find more details about how to contribute to the project. Any support will be welcome :)

@philippfromme philippfromme mentioned this issue Oct 18, 2019
Closed
@nikku nikku added this to the M32 milestone Oct 18, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Oct 18, 2019 — with bpmn-io-tasks
barmac added a commit that referenced this issue Oct 29, 2019
@barmac
feat(hit-policy): allow to clear aggregation from dropdown
b31f84d 
This reimplements the once existing LIST aggregation. The DMN 1.1
as well as DMN 1.2 specs don't mention the LIST aggregation, so it
might have been confusing to re-implement the same naming without
any specification grounds.

Closes #370
Closes #389
@barmac barmac self-assigned this Oct 29, 2019
@barmac barmac added needs review Review pending and removed ready Ready to be worked on labels Oct 29, 2019
@barmac barmac mentioned this issue Oct 29, 2019
Merged
@barmac barmac added in progress Currently worked on and removed needs review Review pending labels Oct 31, 2019 — with bpmn-io-tasks
barmac added a commit that referenced this issue Oct 31, 2019
@barmac
feat(hit-policy): allow to clear aggregation from dropdown
bb59be0 
Closes #370
Closes #389
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 31, 2019
@fake-join fake-join bot closed this as completed in #420 Nov 5, 2019
fake-join bot pushed a commit that referenced this issue Nov 5, 2019
@barmac @fake-join
feat(hit-policy): allow to clear aggregation from dropdown
6fc458d 
Closes #370
Closes #389
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
Decision Table enhancement New feature or request pr welcome We rely on a community contribution to improve this.
Milestone
M32
Development

Successfully merging a pull request may close this issue.

Allow to clear aggregation from dropdown bpmn-io/dmn-js
3 participants
@nikku @sebwarnke @barmac